Skip to content

feat: fallback control#1028

Open
LWWZH wants to merge 3 commits intofeeluown:masterfrom
LWWZH:fallback-control
Open

feat: fallback control#1028
LWWZH wants to merge 3 commits intofeeluown:masterfrom
LWWZH:fallback-control

Conversation

@LWWZH
Copy link
Copy Markdown
Contributor

@LWWZH LWWZH commented Apr 20, 2026

用户可以在设置界面选择禁用fallback机制,详见 #460

closes #460

@cosven
Copy link
Copy Markdown
Member

cosven commented Apr 21, 2026

这是一种解法。

这个解法有一个问题是播放栏右边的按钮越来越多,宽度有点过宽了,我在想有没有啥其它地方可以放这个按钮 🤔 (我自己也没想特别好)
image

@LWWZH
Copy link
Copy Markdown
Contributor Author

LWWZH commented Apr 21, 2026

@cosven
这个FallbackButton是加在settings.py也就是App Configuration界面内(考虑到用户应该不会频繁使用这个功能,也能避免你提到的播放栏按钮过多的问题)

截图

Screenshot 2026-04-21 193156

@cosven
Copy link
Copy Markdown
Member

cosven commented Apr 21, 2026

@cosven 这个FallbackButton是加在settings.py也就是App Configuration界面内(考虑到用户应该不会频繁使用这个功能,也能避免你提到的播放栏按钮过多的问题)

截图

Screenshot 2026-04-21 193156

我看行,这样好。

Comment thread feeluown/app/config.py
desc=t("enable-replace-playlist-on-dblclick-desc"),
)
config.deffield(
"ENABLE_FALLBACK",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在有一个叫做 PROVIDERS_STANDBY,含义是提供 STANDBY 的 providers 列表。

我觉得可以这样设计:当列表为空的时候,代表禁用 STANDBY。也就是相当于这里的 ENABLE_FALLBACK=false

Comment thread feeluown/gui/components/btns.py Outdated
super().showEvent(e)


class FallbackButton(TextButton):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前咱们的设计是弄一个按钮:表示是否开启。
而考虑 PROVIDERS_STANDBY 这个设计,我觉得这个组件可以换一下:直接展示一个有序列表。

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

简单点的话,就弄一个 qlineedit,让用户填。

@LWWZH LWWZH requested a review from cosven May 1, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

允许用户临时禁用fallback机制

2 participants