fix(messaging): macos incorrect parsing of notification response in application_onDidFinishLaunchingNotification#17231
Conversation
…inishLaunchingNotification
steffenhaak
changed the title
| // Setup UIApplicationDelegate. | ||
| #if TARGET_OS_OSX | ||
| NSDictionary *remoteNotification = notification.userInfo[NSApplicationLaunchUserNotificationKey]; | ||
| UNNotificationResponse *notificationResponse = notification.userInfo[NSApplicationLaunchUserNotificationKey]; |
There was a problem hiding this comment.
Hey there, I am sorry I did not see this sooner. It looks alright to me. Can I get you to fix formatting issues that occured on CI? Should be very quick.
There was a problem hiding this comment.
Hi @MichaelVerdon , I am very sorry, I unfortunately lost sight of your message. I just ran clang-format (see latest commit), so the tests now should pass. Can you approve another test run?
There was a problem hiding this comment.
Hi there thanks for the ping @steffenhaak I will be checking this out properly
There was a problem hiding this comment.
Hi @MichaelVerdon, did you ever get a chance to re-review this fix? It has been a sore spot for one of my applications for a long time unfortunately.
SelaseKay
changed the title
application_onDidFinishLaunchingNotification
|
Hi @steffenhaak, sorry for the delayed response. Kindly merge |
4 participants
Description
See bug report in related issue.
Related Issues
#17230
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?