feat(cli): style device-id cert callback page with grid background#1811
feat(cli): style device-id cert callback page with grid background#1811jchris wants to merge 1 commit into
Conversation
Replace the plaintext "Certificate received successfully. You can close this window." response on localhost:PORT/cert with a small HTML page that has a graph-paper grid background, a centered card, and dark-mode support. This is the last screen a user sees during `vibes-diy login`, so it's worth not being raw text/plain. Refs: VibesDIY/vibes.diy#1616 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR adds an HTML response helper function for the device certificate registration flow. A new ChangesCertificate Success HTML Response
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Certificate received successfully. You can close this window.response onlocalhost:PORT/cert(thevibes-diy logincallback) with a small styled HTML page: graph-paper grid background, centered card, dark-mode aware.certSuccessHtml()helper in cli/cmds/device-id-cmd.ts; no new deps;c.text(...)->c.html(...).Test plan
pnpm install && pnpm lint && pnpm buildfrom repo rootvibes-diy loginend-to-end against vibes.diy and confirm the localhost callback page renders the styled card with the grid background (light + dark)vibes-diycontinues past the login step)http://localhost:PORT/certwithout acert=query and confirm the existing 400 error path is unchanged🤖 Generated with Claude Code
Summary by CodeRabbit