fix: validate cached instanceApiVersion before use @W-23157155@#1307
Open
WillieRuemmele wants to merge 2 commits into
Open
fix: validate cached instanceApiVersion before use @W-23157155@#1307WillieRuemmele wants to merge 2 commits into
WillieRuemmele wants to merge 2 commits into
Conversation
… v50 fallback @W-23157155@
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getCachedApiVersion()now validates the cachedinstanceApiVersionviavalidateApiVersion()before returning it. Invalid values (e.g."latest") are logged at warn level and ignored, forcing a fresh fetch fromservices/data.AuthInfo.update()strips invalidinstanceApiVersionvalues before persisting, preventing the poisoned-cache scenario at the source.useLatestApiVersion()now logs the actual version being fallen back to (e.g.v50.0) so the degradation is visible in debug output.Work Item
@W-23157155@: getCachedApiVersion() returns cached instanceApiVersion without re-validating, silently degrading to jsforce default (v50)
Proof of Work
Test plan
instanceApiVersion: "latest"in~/.sfdx/<username>.jsonand verifyconnection.getApiVersion()returns the org's real max version (not50.0)AuthInfo.save({ instanceApiVersion: 'latest' })strips the invalid value and logs a warning"61.0") are still used from cache without a network call