Add Odin documentation#2687
Open
jask06 wants to merge 4 commits into
Open
Conversation
Author
|
Please let me know if there are any issues with the current PR! |
simon04
reviewed
Jun 21, 2026
Comment on lines
+32
to
+35
| options[:attribution] = <<-HTML | ||
| © 2016-#{Date.today.year} Ginger Bill<br> | ||
| Licensed under the 3-clause BSD License. | ||
| HTML |
Contributor
There was a problem hiding this comment.
The license has been changed, see odin-lang/Odin@842cfee.
Comment on lines
+3
to
+5
| self.name = 'Odin Packages' | ||
| self.slug = 'odin_packages' | ||
| self.type = 'odin_packages' |
Contributor
There was a problem hiding this comment.
I would prefer to have this separate scraper to be merged with the main odin. Using one without the other does not seem overly helpful to me. Also, this follows practice we've been following for other scrapers (such as crystal or rust).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you’re adding a new scraper, please ensure that you have:
public/icons/your_scraper_name/directory:16.png: a 16×16 pixel icon for the doc16@2x.png: a 32×32 pixel icon for the docSOURCE: A text file containing the URL to the page the image can be found on or the URL of the original image itselfNOTE: No 16@2x.png image was available from the Odin repo, so I used
https://convertico.com/favicon-resizer/to upscale the available 16x16 image.This should also satisfy #2632
Please let me know your thoughts!