Improve size tracking consistency in rotating_file_sink#3628
Closed
sage-mode-hunter wants to merge 6 commits into
Closed
Improve size tracking consistency in rotating_file_sink#3628sage-mode-hunter wants to merge 6 commits into
sage-mode-hunter wants to merge 6 commits into
Conversation
gabime
requested changes
Jun 26, 2026
| break; | ||
| } | ||
| if (filenames.empty() && !path_exists(new_filename)) { | ||
| break; |
Owner
There was a problem hiding this comment.
this logic is wrong. and not related to the pr. pls revert it
| file_helper_.flush(); | ||
| if (file_helper_.size() > 0) { | ||
| rotate_(); | ||
| current_size_ = file_helper_.size(); |
Owner
There was a problem hiding this comment.
no need to call twice file_helper_.size(). just store into var the first result and use it. logic is wrong amyway, sinice lime 125 sets again the current size
Contributor
Author
There was a problem hiding this comment.
Thanks for the review , I’ve removed the unrelated daily_file_sink change and updated rotating_file_sink to avoid duplicate size calls as suggested.
Owner
There was a problem hiding this comment.
Sorry this doesnt make any sense to me. Now size() is called in each call. Closing.
sage-mode-hunter
force-pushed
the
improve-rotating-file-sink-size-tracking
branch
from
dde7152 to
21a555c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rotating_file_sink uses an internal cached size counter to track file growth and determine when log rotation should occur.
In environments where files may be externally modified (log rotation tools, truncation, or unexpected writes), this cached value can become temporarily inconsistent with the actual file size.
This change adds a lightweight resynchronization after rotation to ensure internal state remains consistent with the underlying file.
No change to rotation behavior or public API.