Conversation
Datadog's hosted MCP server requires OAuth Dynamic Client Registration (DCR, RFC 7591) for third-party clients, and DCR is not exposed by Datadog. The @sentry/junior-datadog package therefore cannot complete the OAuth handshake today. Add a prominent disclaimer at the top of the package README and the Datadog plugin tutorial page so operators do not deploy it expecting it to work, and mark the package as non-functional in the monorepo README package table. Co-Authored-By: Devin AI <devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@sentry/junior-datadogcan't actually connect today: Datadog's hosted MCP server (mcp.datadoghq.com) requires OAuth 2.1 + PKCE, but does not expose Dynamic Client Registration (DCR, RFC 7591) for third-party clients like Junior. Without DCR (or an equivalent registration path), Junior has no way to register an OAuth client, so the auth handshake fails at connect time and every Datadog tool call fails.Rather than yank the plugin, per David's call we're keeping it in-tree and slapping a big disclaimer on it so nobody deploys it expecting it to work. When Datadog opens up DCR, we flip the disclaimer off.
Changes:
packages/junior-datadog/README.md: adds a> [!WARNING]callout at the top explaining the DCR lockdown and that the package is not production-ready.packages/docs/src/content/docs/extend/datadog-plugin.md: adds the same disclaimer as a Starlight:::dangeraside at the top of the tutorial page so it's visible on junior.sentry.dev.README.md: marks@sentry/junior-datadogas non-functional in the package table, linking to the package README.No plugin, manifest, or runtime code is touched — this is docs/README only.
Review & Testing Checklist for Human
README.mdpackage-table should also drop the Datadog row entirely instead of marking it non-functional. I left it in since the package is still shipped.Notes
:::dangerasides out of the box, but nothing else inpackages/docscurrently uses asides, so thedatadog-plugin.mdpage is the first to render one. Confirmed viapnpm docs:checkthat the build succeeds and produces/extend/datadog-plugin/.pnpm lintpasses. No typecheck/test changes since this is docs-only.@sentry/junior-datadogfromapps/example/plugin-packages.ts,.craft.yml, or the release workflow. Happy to do that as a follow-up if you'd rather stop publishing releases until it works.Link to Devin session: https://app.devin.ai/sessions/b41bfa31002d4335adca8cdb0d7cdf4d
Requested by: @dcramer