fix(seer): add GitLab support to web vitals Seer eligibility hook#117747
Open
billyvg wants to merge 2 commits into
Open
fix(seer): add GitLab support to web vitals Seer eligibility hook#117747billyvg wants to merge 2 commits into
billyvg wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CW-1504.
What
useHasSeerWebVitalsSuggestionswas gating onrepo.provider.includes('github')— a substring match that misses'gitlab'entirely. Also the hook comment said "Project has a github repository set up".Changes:
useSeerSupportedProviderIds()fromautofix/utils(already feature-flag-aware for GitLab)hasGithubReposwithhasSupportedReposusing an exactincludescheck against the provider ID listWhy
useSeerSupportedProviderIdsis the canonical frontend equivalent of the backend'sget_supported_scm_providers— it already handles theseer-gitlab-supportflag. Using it here is the correct pattern. Companion BE PR: #117746View Session in Sentry