Skip to content

impl Debug for TextureBlitter#9730

Merged
cwfitzgerald merged 1 commit into
gfx-rs:trunkfrom
euclio:blitter-debug
Jun 24, 2026
Merged

impl Debug for TextureBlitter#9730
cwfitzgerald merged 1 commit into
gfx-rs:trunkfrom
euclio:blitter-debug

Conversation

@euclio

@euclio euclio commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Description

Derives Debug for TextureBlitter and its builder. This makes it easier for downstream structures to derive Debug as well.

It might make sense to enable warn(missing_debug_implementations) at the crate level to catch issues like this, but there are some structs that have a non-derivable implementation, and I noticed that there are otherwise no manual Debug implementations in the codebase.

Testing

N/A.

Squash or Rebase?

N/A

Checklist

  • I self-reviewed and fully understand this PR.
  • WebGPU implementations built with wgpu may be affected behaviorally.
  • Validation and feature gates are in place to confine behavioral changes.
  • Tests demonstrate the validation and altered logic works.
  • CHANGELOG.md entries for the user-facing effects of this change are present.
  • The PR is minimal, and doesn't make sense to land as multiple PRs.
  • Commits are logically scoped and individually reviewable.
  • The PR description has enough context to understand the motivation and solution implemented.

@cwfitzgerald cwfitzgerald self-assigned this Jun 24, 2026

@cwfitzgerald cwfitzgerald left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding missing_debug_implementations seems reasonable, we can manually derive stuff that needs to be manually derived.

@cwfitzgerald cwfitzgerald merged commit ccf0795 into gfx-rs:trunk Jun 24, 2026
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants