impl Debug for TextureBlitter#9730
Merged
Merged
Conversation
cwfitzgerald
approved these changes
Jun 24, 2026
cwfitzgerald
left a comment
Member
There was a problem hiding this comment.
Adding missing_debug_implementations seems reasonable, we can manually derive stuff that needs to be manually derived.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Derives
DebugforTextureBlitterand its builder. This makes it easier for downstream structures to deriveDebugas well.It might make sense to enable
warn(missing_debug_implementations) at the crate level to catch issues like this, but there are some structs that have a non-derivable implementation, and I noticed that there are otherwise no manualDebugimplementations in the codebase.Testing
N/A.
Squash or Rebase?
N/A
Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.