fix: prevent panic when pkg is nil in packageLine#564
Open
Yanhu007 wants to merge 1 commit intogotestyourself:mainfrom
Open
fix: prevent panic when pkg is nil in packageLine#564Yanhu007 wants to merge 1 commit intogotestyourself:mainfrom
Yanhu007 wants to merge 1 commit intogotestyourself:mainfrom
Conversation
When converting benchmark output, Package() may return nil for packages that only have benchmark events. packageLine then panics trying to access pkg.cached on a nil pointer. Add a nil check for pkg and handle the event without package-level metadata (cached, coverage, shuffleSeed). Fixes gotestyourself#413
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #413
Problem
When converting
go test -benchoutput,Execution.Package()may returnnilfor packages that only have benchmark events (skip/fail actions without a preceding "start" that creates the Package entry).packageLinethen panics onpkg.cachednil dereference.Fix
Add a nil check for
pkgat the top ofpackageLine. When pkg is nil, still output the package path and elapsed time, but skip package-level metadata (cached, coverage, shuffleSeed) that require the Package object.