Add: Restructure feed-filter and add dependency filter functionality#2231
Add: Restructure feed-filter and add dependency filter functionality#2231Kraemii wants to merge 1 commit into
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Kraemii
force-pushed
the
dependecie-filter
branch
from
957ebd8 to
3292129
Compare
github-actions
Bot
added
minor_release
Kraemii
force-pushed
the
dependecie-filter
branch
from
3292129 to
0b03bc9
Compare
github-actions
Bot
added
minor_release
|
Before I review, could you tell me what the motivation is behind this change? I understand that now instead of calling feed-filter directly, we call |
Kraemii
force-pushed
the
dependecie-filter
branch
from
0b03bc9 to
e5aa227
Compare
github-actions
Bot
added
minor_release
Kraemii
force-pushed
the
dependecie-filter
branch
from
e5aa227 to
f31d116
Compare
github-actions
Bot
added
minor_release
Kraemii
force-pushed
the
dependecie-filter
branch
from
f31d116 to
63d8be0
Compare
github-actions
Bot
added
minor_release
|
We need this in order to pursuit the next step for the rust only scanner. With this we can extract single scripts, including their dependencies. After that we can check, which builtin functions are missing in order to be able to execute this stack. Also making adjustments, removing not needed dependencies for testing, removing unwanted functionality is much easier within a the extracted smaller feed. In general testing becomes much easier and faster. |
This restructures the original feed-filter into separate files. Additionally a dependency filter is added. It does not filter based on builtin functions but based on given scipts and their dependencies.
Kraemii
force-pushed
the
dependecie-filter
branch
from
63d8be0 to
e156407
Compare
github-actions
Bot
added
minor_release
| enum Command { | ||
| /// Filter feed based on built-in function coverage. | ||
| BuiltinFilter(BuiltinFilterArgs), | ||
| /// Filter feed based on given root scripts and their dependencies. | ||
| DepFilter(DepFilterArgs), | ||
| } |
There was a problem hiding this comment.
Given that we call the binary as feed-filter already, I feel like we shouldn't repeat the filter word here.
Maybe the variants could be called
ByBuiltin and byDependency or something
2 participants
This restructures the original feed-filter into separate files. Additionally a dependency filter is added. It does not filter based on builtin functions but on dependencies. A single script is given, and all include and script_dependencies are checked. From here out, the collected scripts can be copied into a specified directory.
SC-1583