Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jknndy
requested changes
Apr 23, 2026
Collaborator
jknndy
left a comment
jknndy
left a comment
There was a problem hiding this comment.
Hi @zdenek-stursa , thanks for the PR! I've made two comments for your review
| filtered = [ | ||
| line | ||
| for line in instructions.split("\n") | ||
| if not re.fullmatch(r"\d+\.", line.strip()) |
Collaborator
There was a problem hiding this comment.
Suggested change
| if not re.fullmatch(r"\d+\.", line.strip()) | |
| if not line.strip().endswith(".") or not line.strip()[:-1].isdigit() |
Instead of importing re we can use a string check to see if the line ends with a period and the rest is numeric accomplishing the same output
Comment on lines
+1
to
+2
| import re | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| import re |
Replace re.fullmatch(r"\d+\.", ...) with string-based check
using endswith(".") and isdigit() as suggested by reviewer.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Thank you so much @jknndy for taking the time to review this! 🙏 Your suggestion is spot on — the string-based check is much cleaner and avoids an unnecessary This scraper is particularly close to my heart as it covers my wife's favorite recipe site, so I'm really happy someone had a look at it. Much appreciated! 😊 |
jknndy
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds scraper for albert.cz — Czech supermarket Albert recipe website.
The site uses schema.org/Recipe, with the following customizations:
instructions()— filters out numbered step markers (1.,2., etc.) from HowToStep namesdescription()— reads from<meta name="description">(not present in schema)author()andsite_name()— hardcoded toAlbert(schema author name is empty)Recipes: