ci: update Solo version used in CI tests#2733
Conversation
Up to standards ✅🟢 Issues
|
Signed-off-by: Aashish Pandit <imshubham.22apr@gmail.com>
imshubham22apr-gif
force-pushed
the
ci/update-solo-version
branch
from
a7c74b3 to
e4b9560
Compare
|
Some tests are failing |
Signed-off-by: imshubham22apr-gif <imshubham.22apr@gmail.com>
imshubham22apr-gif
force-pushed
the
ci/update-solo-version
branch
from
78a0be3 to
3d6b748
Compare
There was a problem hiding this comment.
These changes skip the example if we don't get the estimates. Also we don't need the try/catch blocks.
The correct approach here would be a retry mechanism or a wait time
|
@mustafauzunn The changes have been made according to your review. I have removed the try/catch blocks and implemented a retry mechanism for FeeEstimateQuery. Could you please review it again? |
imshubham22apr-gif
force-pushed
the
ci/update-solo-version
branch
from
c76ffa3 to
97d3dfb
Compare
Signed-off-by: imshubham22apr-gif <imshubham.22apr@gmail.com>
imshubham22apr-gif
force-pushed
the
ci/update-solo-version
branch
from
97d3dfb to
a12bab3
Compare
|
Run |
| TransferTransaction tx = createTransferTransaction(client, recipientId); | ||
| FeeEstimateResponse stateEstimate = estimateWithStateMode(client, tx); | ||
| FeeEstimateResponse intrinsicEstimate = estimateWithIntrinsicMode(client, tx); | ||
|
|
There was a problem hiding this comment.
Delete the new lines here and on line 66
2 participants
What does this PR do?
Updates the Solo version used in CI workflows from
v0.65.0tov0.68.0.Why is this needed?
The current version in the workflows is outdated. This change aligns the CI setup with the version referenced in recent updates and discussions (see #2699).
What is included?
soloVersionin.github/workflows/build.ymlNotes :-
v0.68.0) matches the version used in related updates and avoids introducing unverified changes