fix: scope generated protobuf classes under SDK namespace to avoid FQCN conflicts#2737
Open
imshubham22apr-gif wants to merge 1 commit into
Open
Conversation
…nsformation Signed-off-by: Aashish Pandit <imshubham.22apr@gmail.com>
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Complexity | 1 medium |
🟢 Metrics 0 complexity
Metric Results Complexity 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Scopes generated protobuf classes under an SDK-specific namespace to avoid FQCN conflicts when the SDK is used alongside
hedera-protobuf-java-api.Why is this needed?
Some protobuf files define their own
java_package(e.g.com.hedera.hapi.*), which can lead to classpath conflicts if both SDK and protobuf artifacts are present in a project.What is included?
java_packagevalues during generation.protofiles unchangedcom.hedera.hashgraph.sdk.proto.*Notes :-
./gradlew :sdk:assemble