package/bluez5_utils: bump to version 5.83 and fix LE connection abort#100
Conversation
sairon
left a comment
sairon
left a comment
There was a problem hiding this comment.
The existing patches don't apply anymore - the first two have been merged to 5.80, the rest to 5.83 - so they can be all deleted.
There are some (easily fixable) issues with the patch itself, as pointed out below.
Also, it would be better to split this into two commits - one doing the bump and removing the patches, the other adding the patch. Last nit is that the commits to Buildroot itself should have Signed-off-by line too - we don't enforce it but if you wanted to upstream the patches, it's mandatory there. Ideally just keep this PR opened and force-push the new two commits, so the PR can be FF-merged to our branch.
| + } | ||
|
|
||
| if (device_get_auto_connect(device)) { | ||
| DBG("Enabling automatic connections"); No newline at end of file |
There was a problem hiding this comment.
The patch has bad formatting, the missing newline prevents it from applying. With that fixed, it still applies with an offset on clean 5.83 sources:
Applying 0005-device-Fix-device-removal-on-le-connection-abort.patch using patch:
patching file src/device.c
Hunk #1 succeeded at 6233 (offset -38 lines)
| With this fix, the device remains available for the retry, allowing | ||
| the connection to succeed on subsequent attempts. | ||
|
|
||
| Fixes: https://github.com/bluez/bluez/issues/1489 |
There was a problem hiding this comment.
A nit, but the patch also should have Upstream: annotation, pointing to the ML post: https://buildroot.org/downloads/manual/manual.html#_additional_patch_documentation
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Removed patches merged upstream in 5.80 (first two) and 5.83. Changelog: https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/ChangeLog Co-authored-by: J. Nick Koston <nick@koston.org> Signed-off-by: Jan Čermák <sairon@sairon.cz>
…n-abort-by-local Add yet unmerged patch for incorrect device removal after le-connection-abort-by-local event, which can result in inability to retry connection under some circumstances. Fixes: bluez/bluez#1489 Co-authored-by: J. Nick Koston <nick@koston.org> Signed-off-by: Jan Čermák <sairon@sairon.cz>
sairon
force-pushed
the
bluez-5.83-update
branch
from
39a6c23 to
49cc269
Compare
3 participants
Fixes: bluez/bluez#1489