Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
代理是回国模式时,ACL中使用全局模式应该是一个合理的use case。
在代理回国模式/ACL设置全局模式时 首次添加能够正确保存acl信息到dbus
但在
refresh_acl_html时加载已经存储的acl信息导致html element里的ACL table没有正确加载全局代理的option
此时再重启插件就会导致
save()时dbus["ss_acl_mode_" + rowid] = E("ss_acl_mode_" + rowid).value;拿到一个空值 导致ss_acl_mode被从dbus中移除,ACL不生效