feat(marking): borderline observations carried into improve prose#57
Open
hyperpolymath wants to merge 1 commit into
Open
feat(marking): borderline observations carried into improve prose#57hyperpolymath wants to merge 1 commit into
hyperpolymath wants to merge 1 commit into
Conversation
Borderline flags are no longer visual-only — when the composer detects
a significant rating/numeric disagreement, the improve box now ends
with a one-line "Note: ... please verify before pasting." so the
warning travels with the pasted feedback into the .docx.
Sentence shape
- One component, over_rated:
"Note: the reflective learning piece rating sits noticeably above
the numeric performance — please verify before pasting."
- Two+ components in same direction (grouped):
"Note: the X and the Y ratings sit noticeably above the numeric
performance — please verify before pasting."
- Mixed directions (two clauses joined by "; and"):
"Note: the X rating sits noticeably above ...; and the Y rating
sits noticeably below ... — please verify before pasting."
Implementation
- build_improve/5 now receives the borderlines map
- borderline_note/2 groups flags by direction and emits a single
sentence (or nil if no borderlines)
- Inserted between the convention sentence and the killer sentence,
so it sits right before the closer
Tests (55 total, 5 new)
- Single severe over_rated -> note in improve, names component,
reads "noticeably above"
- under_rated direction reads "noticeably below"
- Multiple components in same direction share a clause ("ratings sit")
- Mixed directions -> "; and" join
- No borderlines -> no Note line
Verified locally via standalone elixirc + ExUnit (55/0).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The borderline flags from PR #55 used to be visual-only. Now they travel into the improve prose as a one-line `Note:` sentence, so the warning makes it into the .docx the tutor pastes the feedback into.
Sentence shape
Implementation
Tests
Test plan
Generated with Claude Code.