Feature/Stats for Nerds#878
Open
iminsandiego wants to merge 1 commit into
Open
Conversation
Author
Owner
|
Thanks for recreating the PR - I have to be honest, I didn't like the UX situation we're faced, just because there isn't a nice way to surface functionality on top of the player. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Adds a fullscreen player “Stats for Nerds” overlay showing playback diagnostics:
Implementation Notes
StatsForNerdscomponent rather than embedding stats rendering directly intoVideoPlayer.Videofields only while the overlay is visible and the player is fullscreen.playback.stats_for_nerds, so the overlay state can carry across videos without exposing a settings-screen toggle.Videonode while selecting a seek position.Manual Roku TV validation: