Optimization in framework to support linearFV#32746
Draft
GiudGiud wants to merge 8 commits intoidaholab:nextfrom
Draft
Optimization in framework to support linearFV#32746GiudGiud wants to merge 8 commits intoidaholab:nextfrom
GiudGiud wants to merge 8 commits intoidaholab:nextfrom
Conversation
GiudGiud
force-pushed
the
PR_optim_linearFV
branch
4 times, most recently
from
f8e6143 to
c29b8dc
Compare
Optimize switch for coordinate transform
- the perf graph collects the idle time and would lead app devs on a goose chase
…the node to elem maps
Contributor
|
Job Documentation, step Docs: sync website on 48c476e wanted to post the following: View the site here This comment will be updated on new commits. |
GiudGiud
force-pushed
the
PR_optim_linearFV
branch
from
c29b8dc to
d6e80ae
Compare
…used to be restarted but new unique coord was not
- it already the default - it's actually not relevant for a lot of cases in THM which may use XY or general-RZ
Contributor
|
Job Test, step Results summary on 48c476e wanted to post the following: Framework test summaryCompared against 0961ad1 in job civet.inl.gov/job/3753826. No change Modules test summaryCompared against 0961ad1 in job civet.inl.gov/job/3753826. No change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be on the order of 8% if you trust the profile boxes
For now it's 1% at best.
Anyway the next step is either in the solve or in the FE assembly for the auxvariables
Profile before (PG turned off)
1rank_base_notiming.pdf
Profile after the change in coord sys and dof_index changes:
profile004.pdf
I tried some changes in systemBase to get rid of the 7% or so there but no luck on getting it to pass tests yet.
We'd want to do there:
There is not much else in that loop