feat: Add dot pattern for pie chart#2083
Open
jay-k98 wants to merge 1 commit intoimaNNeo:mainfrom
Open
Conversation
Signed-off-by: Jonas Klock <jonas.klock@exxeta.com>
Owner
|
Hi @jay-k98 Let's see how it goes with #1958 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pattern support for PieCharts was requested in #2082.
This Pull Request will implement this feature.
Solution
Adding a [DotPattern] class to hold required data. Both [PieChartSectionData] and [PieChartStackSegmentData] will accept an optional pattern parameter that defaults to DotPattern.disabled().
When a section is painted, dots are drawn over the full section fill if pattern is enabled. Each stack segment is then painted on top. Segments with their own pattern get dots drawn clipped to that segment's bounds only.
-> Open for optimizations :)
Todo's and Improvements