fix(influxdb3_catalog): guard payload_len against integer overflow#27508
Open
naruto-lgtm wants to merge 1 commit into
Open
fix(influxdb3_catalog): guard payload_len against integer overflow#27508naruto-lgtm wants to merge 1 commit into
naruto-lgtm wants to merge 1 commit into
Conversation
A crafted or corrupt catalog file can set the header payload_len near u64::MAX, overflowing pos + payload_len so the wrapped offset slips past the buffer-length check and the payload slice then panics on an out-of-range index. Use checked_add and reject an out-of-range length as BufferTooShort, matching the reader's existing truncated-file path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro: parse a catalog log or snapshot whose header
payload_lenis set nearu64::MAX.Cause:
read_innercomputespos + payload_lenbefore the buffer-length check, so theusizeadd overflows and the wrapped value passes the check; slicing the payload then indexes out of range and panics.Fix: compute the end offset with
checked_addand reject an overflowing or oversized length asBufferTooShort, the same outcome the reader already gives a truncated file.