[NFC][SYCL][E2E] Split long tests#21862
Open
bratpiorka wants to merge 3 commits intointel:syclfrom
Open
Conversation
b7801bd to
cdc6e25
Compare
cdc6e25 to
ee52230
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR splits several long-running SYCL E2E tests into smaller, more focused binaries to reduce timeout risk on slower test machines.
Changes:
- Split Vulkan/SYCL bindless image interop read/write tests into channel/sample/semaphore-focused test entrypoints.
- Split sampled image read tests into separate 1D and 2D entrypoints, moving shared logic into a common implementation.
- Split WorkGroupMemory “basic usage” coverage into separate pointer vs non-pointer entrypoints, moving shared logic into a common implementation.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_write_2d_unsampled_semaphores.cpp | New semaphore-focused 2D unsampled write test entrypoint including shared implementation. |
| sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_write_2d_unsampled_channels.cpp | New channel-matrix 2D unsampled write test entrypoint including shared implementation. |
| sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_write_2d_unsampled.cpp | Converts former monolithic test into shared implementation (header-like) used by new entrypoints. |
| sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_write_1d_unsampled_semaphores.cpp | New semaphore-focused 1D unsampled write test entrypoint including shared implementation. |
| sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_write_1d_unsampled_channels.cpp | New channel-matrix 1D unsampled write test entrypoint including shared implementation. |
| sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_write_1d_unsampled.cpp | Converts former monolithic test into shared implementation (header-like) used by new entrypoints. |
| sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_read_2d_semaphores.cpp | New semaphore-focused 2D read test entrypoint including shared implementation. |
| sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_read_2d_sampled.cpp | New sampled-only 2D read test entrypoint including shared implementation. |
| sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_read_2d_channels.cpp | New unsampled channel-matrix 2D read test entrypoint including shared implementation. |
| sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_read_2d.cpp | Converts former monolithic test into shared implementation (header-like) used by new entrypoints. |
| sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_read_1d_semaphores.cpp | New semaphore-focused 1D read test entrypoint including shared implementation. |
| sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_read_1d_sampled.cpp | New sampled-only 1D read test entrypoint including shared implementation. |
| sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_read_1d_channels.cpp | New unsampled channel-matrix 1D read test entrypoint including shared implementation. |
| sycl/test-e2e/bindless_images/vulkan_interop/vulkan_sycl_image_interop_read_1d.cpp | Converts former monolithic test into shared implementation (header-like) used by new entrypoints. |
| sycl/test-e2e/bindless_images/read_sampled_2d.cpp | New 2D-only sampled image read test entrypoint calling shared helpers. |
| sycl/test-e2e/bindless_images/read_sampled_1d.cpp | New 1D-only sampled image read test entrypoint calling shared helpers. |
| sycl/test-e2e/bindless_images/read_sampled.cpp | Converts former monolithic sampled read test into shared implementation with reusable runAll1D/runAll2D. |
| sycl/test-e2e/WorkGroupMemory/basic_usage_test_ptr.cpp | New pointer-types WorkGroupMemory basic usage test entrypoint including shared helpers. |
| sycl/test-e2e/WorkGroupMemory/basic_usage_test.cpp | New non-pointer WorkGroupMemory basic usage test entrypoint including shared helpers. |
| sycl/test-e2e/WorkGroupMemory/basic_usage.cpp | Converts former monolithic WorkGroupMemory test into shared implementation (header-like) used by new entrypoints. |
ee52230 to
3fb56af
Compare
Contributor
Author
|
@uditagarwal97 applied copilot suggesions |
3fb56af to
66156bb
Compare
uditagarwal97
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits a long‑running test that could time out on slower machines (e.g. new system used for testing CUDA 13):