[SYCL RTC] Exclude CMake files#21879
Open
kilyanni wants to merge 1 commit intointel:syclfrom
Open
Conversation
kilyanni
force-pushed
the
fix/sycl-jit-cmake-leak
branch
from
9a6c977 to
ed0b7e5
Compare
cperkinsintel
approved these changes
Apr 28, 2026
Contributor
cperkinsintel
left a comment
cperkinsintel
left a comment
There was a problem hiding this comment.
good catch. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment,
sycl-jitembeds various files at build-time. Among these are some CMake build files, which contain absolute paths to the build directory.This leaks details about the build environment to the final binaries, which also introduces a small reproducibility issue, where building from different folders causes the final binary to change.
As far as I can tell, nothing expects the CMake files to be bundled and it's safe to skip then, so that's what this PR does: skip any CMake files during embedding.