Support importId, email and freeSwitchExtension lookups in users_info#387
Merged
Conversation
users_info previously restricted lookups to user_id and username, raising an exception before any other lookup parameter could be used. The API (get-users-info) accepts userId, username, importId, email (>= 8.4.0) and freeSwitchExtension (>= 8.5.0), with exactly one required per request. Add import_id, email and free_switch_extension parameters, mapping them to the documented importId/email/freeSwitchExtension query parameters, and update the missing-param error message accordingly. Closes #386
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #387 +/- ##
=======================================
Coverage 99.35% 99.36%
=======================================
Files 53 53
Lines 2803 2831 +28
Branches 157 160 +3
=======================================
+ Hits 2785 2813 +28
Misses 14 14
Partials 4 4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #386.
users_infoonly alloweduser_idandusernameand raised before any other lookup could be used. The API also acceptsimportId,email(>= 8.4.0) andfreeSwitchExtension(>= 8.5.0), so the method now takesimport_id,emailandfree_switch_extensiontoo. Older servers are unaffected since the wrapper just forwards whichever parameter is given.