This repository was archived by the owner on Sep 30, 2019. It is now read-only.
wip: Use cats instead of uscala#14
Open
lorandszakacs wants to merge 16 commits intojanstenpickle:masterfrom
Open
wip: Use cats instead of uscala#14lorandszakacs wants to merge 16 commits intojanstenpickle:masterfrom
lorandszakacs wants to merge 16 commits intojanstenpickle:masterfrom
Conversation
The purpose of this is to preserve the syntax of AsyncResult and Result as much as possible. To get compiled code faster. Next step is to remove the redundant String type parameter on the left side of the Either, and make it fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still a wip:
type AsyncEitherT[R] = cats.data.EitherT[Future, String, R]. AsyncResult can bear to lose the generic "failure" type, and have it be fixed atString