Skip to content

Add isActive boolean flag in the Customer table #130#132

Open
ShraiyaShah wants to merge 1 commit intojaygajera17:master2from
ShraiyaShah:MyBranch
Open

Add isActive boolean flag in the Customer table #130#132
ShraiyaShah wants to merge 1 commit intojaygajera17:master2from
ShraiyaShah:MyBranch

Conversation

@ShraiyaShah
Copy link
Copy Markdown

A new field in User "isActive" to describe the status of the user handled by Admin through "displayCustomer" page. It imitates Soft delete of the user.

Copy link
Copy Markdown

@abdurraffaysyed abdurraffaysyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ShraiyaShah,
Shouldn't the endpoint be named as deleteCustomer instead of deleteUser. As we are dealing with the Customers so I was thinking deleteCustomer would be more meaningful here. What do you say?

@ShraiyaShah
Copy link
Copy Markdown
Author

Hi, Thank you for raising the point. I have used "User" because in update method "updateUser" is used.

Copy link
Copy Markdown

@abdurraffaysyed abdurraffaysyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ShraiyaShah,
Correct me if I am wrong, according to the current implementations once the admin De-Activates a customer then as expected that customer won't be visible on the UI. If that customer is not visible then how will the Admin be able to Activate that customer again?

@ShraiyaShah
Copy link
Copy Markdown
Author

Hi, @abdurraffaysyed
No, The User remains visible, the link "De-activate" turns into "Activate". And the user whose profile is De-activated, won't be able to login.
User

@abdurraffaysyed
Copy link
Copy Markdown

@ShraiyaShah,
But isn't delete supposed to remove the record from the UI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants