Skip to content

dark mode for galene interface#92

Open
RayBoucherit wants to merge 1 commit into
jech:masterfrom
RayBoucherit:dark-mode
Open

dark mode for galene interface#92
RayBoucherit wants to merge 1 commit into
jech:masterfrom
RayBoucherit:dark-mode

Conversation

@RayBoucherit

Copy link
Copy Markdown

No description provided.

@MisterDA

Copy link
Copy Markdown
Contributor

There's a CSS media query for the color scheme ; the user sets that preference globally (in the browser or the OS). Galène can use it for the default color sheme.
https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme

@jech

jech commented Jun 9, 2021

Copy link
Copy Markdown
Owner

@takdj ?

@takdj

takdj commented Jun 10, 2021

Copy link
Copy Markdown
Contributor

I think in this case, only color and background properties should be overwritten, for example:

.app-dark {
    background-color: #212529;
    box-shadow: 0 1px 1px 0 rgba(90, 89, 89, 0.06), 0 2px 5px 0 rgba(0, 0, 0, .2);
}

@jech jech force-pushed the master branch 2 times, most recently from 4f84b48 to 0d2ca28 Compare July 15, 2021 23:40
@jech

jech commented Aug 7, 2021

Copy link
Copy Markdown
Owner

@4h30, @takdj, what's the consensus on this?

@takdj

takdj commented Aug 9, 2021

Copy link
Copy Markdown
Contributor

the dark mode feature is good but for me, It's required to update patch to change only color and background properties on dark mode. Else maintaining css will become harder.
On javascript side, it's also better to set class 'app-dark' only on main div then, propagate dark style in css to children div.

@foresto

foresto commented Feb 15, 2026

Copy link
Copy Markdown

There's a CSS media query for the color scheme ; the user sets that preference globally (in the browser or the OS).

It's worth noting that this media query doesn't work for people who use Firefox Resist Fingerprinting Mode. Since RFP mode appeals to the same sort of people who would choose Galene instead of e.g. Zoom, it would probably make sense to also expose a widget that would activate dark mode when clicked. (This could be done in pure CSS with a styled checkbox, allowing it to work with no javascript overhead.)

@jech jech force-pushed the master branch 2 times, most recently from 62db327 to 888aa9b Compare March 8, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants