[6.2] Add LocalBusiness schema type plugin#47667
[6.2] Add LocalBusiness schema type plugin#47667mortezahonar wants to merge 32 commits intojoomla:6.2-devfrom
Conversation
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
|
Sorry, I wanted to change my branch name, which caused the PR to close. I have reopened it, and I won't change the branch name until this PR is reviewed. Sorry for adding a few unnecessary commits. |
Added telephone property to LocalBusiness schema
Added language string for telephone property in LocalBusiness
|
Hi @mortezahonar - thank you for this PR, potentially great addition to Joomla. You mention: Install the plugin by copying the localbusiness folder to /plugins/schemaorg/ or install via zip. I could not find a zip file or a localbusiness folder that you are referring to. Could you please provide that attachment and update the TESTING INSTRUCTIONS? thank you so much. |
|
Thanks, Emmanuel. Yes, unfortunately the file hasn't been uploaded. |
|
I have tested this item ✅ successfully |
|
This pr needs to have sql changes in the installation sql so that the plugin is avilable on new installs and update sql for updated sites |
Sorted language strings alphabetically in plg_schemaorg_localbusiness
[6.2] Added plg_schemaorg_localbusiness to installation SQL in alphabetical order
[6.2] Added plg_schemaorg_localbusiness to installation
delet localbusiness
[6.2] Update postgresql/base.sql for LocalBusiness plugin
|
Testing InstructionsPrerequisite: Step 1: Add Language FilesDownload the following two language files from
Copy both files to the same path on your Joomla installation: Step 2: Modify Database Installation FilesEdit the following SQL files inside your nightly build package:
Find this section: (0, 'plg_schemaorg_organization', 'plugin', 'organization', 'schemaorg', 0, 1, 1, 0, 1, '', '{}', '', 6, 0),
(0, 'plg_schemaorg_person', 'plugin', 'person', 'schemaorg', 0, 1, 1, 0, 1, '', '{}', '', 7, 0),
(0, 'plg_schemaorg_recipe', 'plugin', 'recipe', 'schemaorg', 0, 1, 1, 0, 1, '', '{}', '', 8, 0),
(0, 'plg_schemaorg_custom', 'plugin', 'custom', 'schemaorg', 0, 1, 1, 0, 1, '', '{}', '', 9, 0),Replace with: (0, 'plg_schemaorg_localbusiness', 'plugin', 'localbusiness', 'schemaorg', 0, 1, 1, 0, 1, '', '{}', '', 6, 0),
(0, 'plg_schemaorg_organization', 'plugin', 'organization', 'schemaorg', 0, 1, 1, 0, 1, '', '{}', '', 7, 0),
(0, 'plg_schemaorg_person', 'plugin', 'person', 'schemaorg', 0, 1, 1, 0, 1, '', '{}', '', 8, 0),
(0, 'plg_schemaorg_recipe', 'plugin', 'recipe', 'schemaorg', 0, 1, 1, 0, 1, '', '{}', '', 9, 0),
(0, 'plg_schemaorg_custom', 'plugin', 'custom', 'schemaorg', 0, 1, 1, 0, 1, '', '{}', '', 10, 0),Step 3: Add the PluginDownload the
The folder should contain: Step 4: Install JoomlaInstall Joomla using your modified nightly build package. Step 5: Test the Plugin
Expected ResultThe LocalBusiness schema type appears in the dropdown, form fields are displayed, data is saved to the database and appears as JSON-LD in the frontend with Note: I apologize for not being able to upload the files directly to GitHub at this time due to internet restrictions. I will upload them as soon as possible. Thank you for your understanding. |
|
We understand the internet restrictions you are facing at this time and hope they will be over soon. |
|
you need to add this new plugin here joomla-cms/libraries/src/Extension/ExtensionHelper.php Lines 283 to 292 in 7e8527d |
added localbusiness
Pull Request resolves #
Summary of Changes
This PR adds a new schema.org plugin for LocalBusiness type.
Testing Instructions
localbusinessfolder to/plugins/schemaorg/or install via zip.plg_schemaorg_localbusiness).LocalBusinessfrom the schema type dropdown.<script type="application/ld+json">tag with@type: "LocalBusiness"is present.Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
@type: "LocalBusiness".Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed