feat: add data-item-custom support in JGrid action#47690
Open
jiteshkhatri11 wants to merge 2 commits into
Open
feat: add data-item-custom support in JGrid action#47690jiteshkhatri11 wants to merge 2 commits into
jiteshkhatri11 wants to merge 2 commits into
Conversation
Contributor
|
will you please close all the other attempted PR for this exact same issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request resolves # .
Summary of Changes
Add support for a data-item-custom attribute in JGrid action buttons through an optional custom key in the options array. This allows developers to attach extra metadata to grid action buttons for custom JavaScript handling.
Testing Instructions
Pass a custom key in the options array when calling JGrid::action() and verify the data-item-custom attribute appears in the rendered HTML output.
Actual result BEFORE applying this Pull Request
JGrid action buttons do not support custom data attributes.
Expected result AFTER applying this Pull Request
JGrid action buttons render a data-item-custom attribute when a custom key is provided in the options array.
Link to documentations