🧪 Add DotWave constructor test coverage#10
Conversation
- Add mock-browser.js to provide necessary DOM globals - Add dotwave.test.js to assert constructor defaults and option overriding - Run via node using built-in assert module Co-authored-by: jsem-nerad <88319121+jsem-nerad@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
Adds a lightweight Node-based test setup (no JSDOM/Playwright) to validate the DotWave constructor’s default configuration and basic option overriding behavior.
Changes:
- Added a minimal browser/DOM/canvas mock to allow constructing
DotWavein Node. - Added a Node
assert-based test script covering default constructor options and a subset of overrides. - Added
node_modulesto.gitignore.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/mock-browser.js | Introduces a minimal window/document/canvas mock to support constructor execution in Node. |
| tests/dotwave.test.js | Adds constructor/defaults and option override assertions for DotWave. |
| .gitignore | Ignores node_modules to keep local installs out of the repo. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| assert.strictEqual(dw.options.backgroundColor, 'blue', 'backgroundColor should be overridden'); | ||
| assert.strictEqual(dw.options.dotMinSize, 2, 'dotMinSize should be overridden'); | ||
| assert.strictEqual(dw.options.dotMaxSize, 5, 'dotMaxSize should be overridden'); | ||
|
|
| // Load DotWave | ||
| require('../src/dotwave.js'); | ||
| const DotWave = global.window.DotWave; | ||
|
|
||
| try { |
🎯 What: Adds unit testing coverage for the DotWave constructor and configuration options merging.
📊 Coverage: Verifies default configurations and option overrides during initialization.
✨ Result: Increased testing coverage for core functionality without requiring heavy dependencies like JSDOM or Playwright.
PR created automatically by Jules for task 5273869124719067512 started by @jsem-nerad