ci: support for nightly builds#961
Open
yuvrajjsingh0 wants to merge 2 commits intomainfrom
Open
Conversation
|
Review changes with Changed Files
|
Contributor
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughIntroduces reusable GitHub Actions workflows for building Docker images and language artifacts (Java, Python, JavaScript, Rust), adds a nightly release automation workflow with git tag-based versioning, and refactors the release workflow to delegate to these reusable components instead of duplicating build logic inline. Changes
Sequence Diagram(s)sequenceDiagram
participant GHA as GitHub Actions
participant RustBld as generate-rust-binary
participant JavaBld as generate-java-packages
participant PyBld as generate-python-packages
participant JSBld as generate-js-packages
participant CarBld as generate-rust-packages
participant RelBld as release
participant Artifact as Artifact Store
GHA->>RustBld: Start (matrix: Linux/macOS/Windows)
RustBld->>Artifact: Upload platform zips
Artifact->>JavaBld: Await Rust artifacts
Artifact->>PyBld: Await Rust artifacts
Artifact->>JSBld: Await Rust artifacts
Artifact->>CarBld: Await Rust artifacts
JavaBld->>JavaBld: Extract libs, Gradle publish
PyBld->>PyBld: Extract libs, uv build wheels, twine upload
JSBld->>JSBld: Extract libs, npm publish
CarBld->>CarBld: Set versions, cargo publish
JavaBld->>Artifact: Complete
PyBld->>Artifact: Complete
JSBld->>Artifact: Complete
CarBld->>Artifact: Complete
Artifact->>RelBld: All artifacts ready
RelBld->>RelBld: Download artifacts, create GitHub Release
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Adds CI support for automated nightly releases and refactors stable/nightly release pipelines to reuse shared build/publish logic across Docker images and language artifacts.
Changes:
- Introduces a scheduled
nightly_release.yamlworkflow that tags and publishes nightly builds only when there are new commits since the last nightly/stable marker. - Refactors stable release workflow to call new reusable workflows for Docker images and language artifacts publishing.
- Adds reusable workflows
docker_images_common.yamlandlanguage_artifacts_common.yamlto centralize shared release logic.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| .github/workflows/release.yaml | Stable release now delegates docker/language publishing to reusable workflows. |
| .github/workflows/nightly_release.yaml | New scheduled nightly workflow that computes version, tags, detects changes, and triggers publishing. |
| .github/workflows/docker_images_common.yaml | New reusable workflow to build/push multi-arch Docker + demo images and manifests. |
| .github/workflows/language_artifacts_common.yaml | New reusable workflow to build rust binaries, publish language packages, and draft GitHub releases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (4)
.github/workflows/docker_images_common.yaml (1)
30-34: Unnecessary deep checkout in multiple jobs.
fetch-depth: 0fetches the entire git history, which is unnecessary for Docker builds and manifest creation. Thecreate-manifestandcreate-demo-manifestjobs don't need any checkout at all since they only rundocker buildx imagetoolscommands.♻️ Suggested simplifications
For build jobs, use shallow checkout:
- name: Checkout repository uses: actions/checkout@v4 - with: - fetch-depth: 0 - token: ${{ secrets.SUPERPOSITION_TOKEN }}For manifest jobs, remove checkout entirely since no repo files are needed.
Also applies to: 60-64, 100-104, 131-135
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/docker_images_common.yaml around lines 30 - 34, The workflow currently does a full git history checkout via actions/checkout@v4 with fetch-depth: 0; change build-related checkouts to a shallow clone by setting fetch-depth: 1 (replace fetch-depth: 0) for the jobs that actually need the repo, and remove the entire checkout step from the manifest-only jobs (create-manifest and create-demo-manifest) since they only run docker buildx imagetools commands and do not require repository files; update all instances flagged (lines around the other checkouts) accordingly..github/workflows/release.yaml (1)
97-97: Redundantifconditions on dependent jobs.Both
build-docker-imagesandbuild-language-artifactshaveif: github.ref == 'refs/heads/main', but they depend ontag-releasewhich already has this same condition. Iftag-releaseis skipped, these jobs won't run anyway due to theneedsdependency.♻️ Remove redundant conditions
build-docker-images: needs: tag-release - if: github.ref == 'refs/heads/main' uses: ./.github/workflows/docker_images_common.yamlbuild-language-artifacts: needs: tag-release - if: github.ref == 'refs/heads/main' uses: ./.github/workflows/language_artifacts_common.yamlAlso applies to: 106-106
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/release.yaml at line 97, The jobs 'build-docker-images' and 'build-language-artifacts' include redundant "if: github.ref == 'refs/heads/main'" conditions; remove those if lines so they rely on the existing dependency on the 'tag-release' job (which already has that condition) and the 'needs' behavior to skip when appropriate—search for the job blocks named build-docker-images and build-language-artifacts and delete their if: github.ref == 'refs/heads/main' entries (also remove the duplicate at the other occurrence mentioned)..github/workflows/nightly_release.yaml (2)
42-44: Tag sorting by-creatordatemay produce incorrect semantic version order.Using
--sort=-creatordatesorts by tag creation time, not semantic version. If tags are created out of order (e.g., backporting a fix to an older version), this could select the wrong "latest" tag. For example, ifv0.9.1is tagged afterv0.10.0, the former would be selected.Consider using
--sort=-version:refnamefor proper semantic version sorting:♻️ Suggested fix
-latest_release_tag="$(git tag -l --sort=-creatordate | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+(-nightly-[0-9]+)?$' | head -n 1 || true)" -latest_stable_tag="$(git tag -l --sort=-creatordate | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+$' | head -n 1 || true)" -latest_nightly_tag="$(git tag -l --sort=-creatordate | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+-nightly-[0-9]+$' | head -n 1 || true)" +latest_release_tag="$(git tag -l --sort=-version:refname | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+(-nightly-[0-9]+)?$' | head -n 1 || true)" +latest_stable_tag="$(git tag -l --sort=-version:refname | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+$' | head -n 1 || true)" +latest_nightly_tag="$(git tag -l --sort=-version:refname | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+-nightly-[0-9]+$' | head -n 1 || true)"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/nightly_release.yaml around lines 42 - 44, The current tag queries use --sort=-creatordate which orders by creation time and can pick the wrong semantic "latest" tag; update the three commands that set latest_release_tag, latest_stable_tag, and latest_nightly_tag to use --sort=-version:refname instead of --sort=-creatordate (keeping the existing grep patterns for the version and nightly regexes) so tags are selected by semantic version order.
100-107: Misleading variable name:merged_pr_countcounts commits, not PRs.
git rev-list --count --first-parentcounts commits on the first-parent path (i.e., merge commits and direct commits to main), not the number of merged pull requests. A single PR merge is one commit, but direct pushes are also counted.Consider renaming for clarity:
-merged_pr_count="$(git rev-list --count --first-parent "$range")" +commit_count="$(git rev-list --count --first-parent "$range")" should_build="false" -if [[ "$merged_pr_count" -gt 0 ]]; then +if [[ "$commit_count" -gt 0 ]]; then should_build="true" fi -echo "merged_pr_count=$merged_pr_count" >> "$GITHUB_OUTPUT" +echo "commit_count=$commit_count" >> "$GITHUB_OUTPUT"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/nightly_release.yaml around lines 100 - 107, The variable merged_pr_count is misleading because git rev-list --count --first-parent returns commits, not PRs; rename it (e.g., commit_count or merged_commit_count) everywhere it appears and update the echo outputs and any downstream usage (references: merged_pr_count, should_build, and the git command invocation git rev-list --count --first-parent "$range") so the name accurately reflects that you're counting commits rather than merged PRs; leave the logic (setting should_build based on >0) intact but use the new variable name consistently.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/docker_images_common.yaml:
- Around line 83-84: The demo job docker-demo-build currently always uses the
image tag "latest" from the example.Dockerfile and can pull a stale base; update
docker-demo-build (which depends on create-manifest) to pass a build-arg that
sets the base tag to the manifest alias (e.g., alias_tag/nightly) when building
the demo image, and change example.Dockerfile to accept ARG BASE_TAG and use
FROM ghcr.io/juspay/superposition:${BASE_TAG} as runtime so the demo build pulls
the newly published production image; reference the create-manifest job output
(needs.create-manifest.outputs.alias_tag) as the value for BASE_TAG when
invoking the docker build in docker-demo-build.
In @.github/workflows/language_artifacts_common.yaml:
- Around line 65-123: The generate-rust-binary job is missing an explicit
permissions block; add a minimal permissions stanza at the job level (for
example, set permissions.contents: read) so the job declares only the
least-privilege access it needs; update the job definition named
generate-rust-binary to include this permissions block immediately under the job
key (near strategy/runs-on) to satisfy CodeQL/static policy and follow security
best practices.
- Around line 354-359: The workflow step using the dtolnay/rust-toolchain action
(the step named "Install Rust" with uses: dtolnay/rust-toolchain@master)
incorrectly lists "cargo" in the components list; remove "cargo" from the
components array so only valid components (e.g., rustfmt, clippy) are specified,
leaving toolchain and targets as-is.
- Around line 378-386: The publish steps run back-to-back causing registry index
propagation failures; insert 30-second pauses between each cargo publish
invocation so dependent crates have time to appear. Update the workflow block
containing the cargo publish commands (the lines with "cargo publish --package
superposition_derives", "superposition_sdk", "superposition_types",
"superposition_core", "superposition_provider") to run a sleep 30 (or similar
delay) after each publish command except the last, ensuring each crate publish
is followed by a 30s delay before the next publish.
---
Nitpick comments:
In @.github/workflows/docker_images_common.yaml:
- Around line 30-34: The workflow currently does a full git history checkout via
actions/checkout@v4 with fetch-depth: 0; change build-related checkouts to a
shallow clone by setting fetch-depth: 1 (replace fetch-depth: 0) for the jobs
that actually need the repo, and remove the entire checkout step from the
manifest-only jobs (create-manifest and create-demo-manifest) since they only
run docker buildx imagetools commands and do not require repository files;
update all instances flagged (lines around the other checkouts) accordingly.
In @.github/workflows/nightly_release.yaml:
- Around line 42-44: The current tag queries use --sort=-creatordate which
orders by creation time and can pick the wrong semantic "latest" tag; update the
three commands that set latest_release_tag, latest_stable_tag, and
latest_nightly_tag to use --sort=-version:refname instead of --sort=-creatordate
(keeping the existing grep patterns for the version and nightly regexes) so tags
are selected by semantic version order.
- Around line 100-107: The variable merged_pr_count is misleading because git
rev-list --count --first-parent returns commits, not PRs; rename it (e.g.,
commit_count or merged_commit_count) everywhere it appears and update the echo
outputs and any downstream usage (references: merged_pr_count, should_build, and
the git command invocation git rev-list --count --first-parent "$range") so the
name accurately reflects that you're counting commits rather than merged PRs;
leave the logic (setting should_build based on >0) intact but use the new
variable name consistently.
In @.github/workflows/release.yaml:
- Line 97: The jobs 'build-docker-images' and 'build-language-artifacts' include
redundant "if: github.ref == 'refs/heads/main'" conditions; remove those if
lines so they rely on the existing dependency on the 'tag-release' job (which
already has that condition) and the 'needs' behavior to skip when
appropriate—search for the job blocks named build-docker-images and
build-language-artifacts and delete their if: github.ref == 'refs/heads/main'
entries (also remove the duplicate at the other occurrence mentioned).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d2a477bb-fbd6-460f-b174-ee269c193144
📒 Files selected for processing (4)
.github/workflows/docker_images_common.yaml.github/workflows/language_artifacts_common.yaml.github/workflows/nightly_release.yaml.github/workflows/release.yaml
Datron
approved these changes
Apr 21, 2026
Datron
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Daily nightly builds to automate deployments
Solution
Environment variable changes
Pre-deployment activity
Post-deployment activity
API changes
Possible Issues in the future
Describe any possible issues that could occur because of this change
Summary by CodeRabbit