fix: preserve tool_call_id in _create_standard_choice#49
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
OpenAI-compatible providers parse API responses through _create_standard_choice, which dropped tool_call_id from tool-role messages. Azure already handled this in its custom parser; align the shared helper so Grok, DeepSeek, Ollama, and OpenAI keep the ID needed for multi-turn tool calling. Co-authored-by: Darshan Harihar <DarshanHarihar1@users.noreply.github.com>
github-actions
Bot
added
core
tests
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where OpenAI-compatible providers dropped
tool_call_idwhen parsing API responses through the shared_create_standard_choicehelper.Azure OpenAI already preserved this field in its custom response parser (#40), but Grok, DeepSeek, Ollama, and OpenAI use the shared helper — so tool-role messages lost the ID required for multi-turn tool calling.
Changes
tool_call_idthrough inBaseProvider._create_standard_choicetests/test_base_provider.pywith regression coverageBranch
Feature branch:
darshan/fix-standard-choice-tool-call-idTesting
All CI checks pass locally:
ruff check justllms/black --check justllms/ tests/mypy justllms/ --ignore-missing-importspytest tests/ -v(96 passed)python3 -m build