fix: register provider aliases (xai/grok) on client init#53
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
When XAI_API_KEY is loaded via Config.from_env(), the grok provider is initialized but the xai alias was missing. SXS and explicit provider='xai' calls failed with Provider not found. Register all known aliases (xai, claude, gemini) that share the same provider class after initialization, without overwriting explicitly configured alternate names. Co-authored-by: Darshan Harihar <DarshanHarihar1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where provider aliases were not registered on the
Client, causingprovider="xai"calls to fail when onlyXAI_API_KEYis set (which configures thegrokprovider key).Problem
Config.from_env()registers xAI under thegrokkey whenXAI_API_KEYis setprovider="xai"as the provider nameget_provider_class("xai")works at the registry level, butClient.providersonly contained"grok", leading to Provider 'xai' not found errorsSolution
Added
_register_provider_aliases()to automatically register alternate provider names (e.g.xai/grok,claude/anthropic,gemini/google) that share the same provider class when a provider is initialized or manually added viaadd_provider().Separately configured aliases are not overwritten.
Tests
Added
tests/test_provider_aliases.pywith 4 test cases.CI
All checks pass: ruff, black, mypy, pytest (98 tests), build.