Move Sources parsing to new SourceryParser target#928
Open
hectr wants to merge 2 commits intokrzysztofzablocki:masterfrom
Open
Move Sources parsing to new SourceryParser target#928hectr wants to merge 2 commits intokrzysztofzablocki:masterfrom
hectr wants to merge 2 commits intokrzysztofzablocki:masterfrom
Conversation
Generated by 🚫 Danger |
e1b75db to
8d1ff6c
Compare
41df996 to
ae34fa7
Compare
2e73997 to
1594839
Compare
6685b14 to
e1517aa
Compare
82de678 to
1e05847
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposing Sourcery's
ParsingResult, would allow other applications to access the wholeTypesobject in just a few lines of code. Which I believe would be a nice addition to the many already existing options for interacting with Sourcery.This is just an idea/proposal, I would say it is related with #501 .
I have simply moved existing code to a new target and changed acls accordingly 😄