Skip to content

db: remove IsNoRows#8733

Merged
jsha merged 1 commit intomainfrom
no-is-no-rows
Apr 24, 2026
Merged

db: remove IsNoRows#8733
jsha merged 1 commit intomainfrom
no-is-no-rows

Conversation

@jsha
Copy link
Copy Markdown
Contributor

@jsha jsha commented Apr 24, 2026

Its original purpose was to unwrap an ErrDatabaseOp, but we can now do that easily with errors.Is. Eliminating the trivial wrapper makes things clearer.

It was originally added in #4585.

Its original purpose was to unwrap an ErrDatabaseOp, but we can now do that
easily with `errors.Is`. Eliminating the trivial wrapper makes things clearer.
@jsha jsha marked this pull request as ready for review April 24, 2026 01:03
@jsha jsha requested a review from a team as a code owner April 24, 2026 01:03
@jsha jsha requested a review from aarongable April 24, 2026 01:03
@jsha jsha merged commit bc88c53 into main Apr 24, 2026
17 checks passed
@jsha jsha deleted the no-is-no-rows branch April 24, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants