deps: pin @multiformats/multiaddr to 13.0.1#3500
Merged
Merged
Conversation
13.0.2 silently bumped peer-deps to multiformats@^14 and uint8arrays@^6, causing duplicate multiformats installs that break dial-queue browser tests via class-mangling in sinon's withArgs matcher.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@multiformats/multiaddr@13.0.2silently bumped peer-deps:multiformats:^13.4→^14uint8arrays:^5→^6npm now installs both
multiformatsversions side-by-side, esbuild shipsduplicates in browser bundles, and class-mangling breaks sinon's
withArgs(peerId)matcher (constructor.namemismatch) → dial-queuebrowser tests fail.
Pin multiaddr to 13.0.1 via root
overridesuntil we do the coordinatedmultiformats@^14/uint8arrays@^6bump across libp2p packages.Change checklist