feat(transport-interop): add Haskell (libp2p-hs) implementation#857
Open
adust09 wants to merge 2 commits into
Open
feat(transport-interop): add Haskell (libp2p-hs) implementation#857adust09 wants to merge 2 commits into
adust09 wants to merge 2 commits into
Conversation
Register libp2p-hs as a transport-interop implementation (haskell-v0.1), supporting TCP + Noise + Yamux. - impl/haskell/v0.1/Makefile: fetches libp2p-hs at a pinned commit and builds its root Dockerfile (which produces the libp2p-interop daemon) via dockerBuildWrapper.sh, writing image.json. - versionsInput.json: add haskell-v0.1 (transports: tcp, secureChannels: noise, muxers: yamux). containerImageID is omitted so the canonical image.json lookup is used.
The haskell-v0.1 entry lacked a containerImageID, so versions.ts fell back to canonicalImageIDLookup and the run-transport-interop job tried to read a local ./impl/haskell/v0.1/image.json that does not exist in CI, failing with ENOENT. Reference the GHCR image like every other implementation so the test pulls it from the registry instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register libp2p-hs as a transport-interop implementation (haskell-v0.1), supporting TCP + Noise + Yamux.