fix: use SQLAlchemy .is_(False) instead of Python is False in FileRecord queries#24
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Conversation
…ecord queries
The filter condition 'FileRecord.is_deleted is False' uses Python's identity
check ('is') instead of SQLAlchemy's comparison method. Since
FileRecord.is_deleted is a Column object (not the Python False singleton),
'is False' always evaluates to Python False, causing the filter to silently
match no rows.
This breaks both execute_jmx_async() and execute_jmx_sync_dev() — uploaded
JMX files can never be found for execution, resulting in spurious 404 errors.
Fix: replace 'is False' with '.is_(False)' which generates the correct
SQL 'IS FALSE' clause.
Co-Authored-By: 花菜 <lihuacai168@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a critical bug in
core/jmeter.pywhere two SQLAlchemy queries use Python's identity operator (is False) instead of SQLAlchemy's.is_(False)method to filterFileRecord.is_deleted.FileRecord.is_deleted is Falseperforms a Python identity check — since a SQLAlchemyColumnobject is never theFalsesingleton, this expression always evaluates to PythonFalse. The resulting.filter(..., False)adds aWHERE falseclause, so the query always returns zero rows. This means bothexecute_jmx_async()andexecute_jmx_sync_dev()silently fail to find any uploaded JMX file, returning a 404 on every execution attempt.Review & Testing Checklist for Human
/executeendpoint — confirm it no longer returns 404is Falseoris Trueon SQLAlchemy column attributes (e.g.grep -rn 'is False\|is True' --include='*.py') — there may be similar bugs elsewhereFileRecordrows in your database haveis_deleted = falseso the corrected query actually matches themNotes
JMeterManagerLink to Devin session: https://app.devin.ai/sessions/4a764a33364c48478f6bb95d29af0007
Requested by: @lihuacai168