Implement DSP/Cmajor code for 'Cabasa' (Midi note 69)#82
Merged
Conversation
| } | ||
|
|
||
| float jitter = (noise.out * 0.0003f); | ||
| int silentSamples = int((burstSpacing + jitter) * 44100.0f); |
Owner
There was a problem hiding this comment.
Same comment as here: #80 (comment)
I don't think we need this
Owner
There was a problem hiding this comment.
oh wait no sorry, I am reading this wrong, this is to space out bursts of one "hit" of the instrument. We do need it, but we should use float(processor.frequency) instead of hardcoding a 44.1khz sample rate.
Contributor
Author
There was a problem hiding this comment.
Good catch, I added that!
lilyvanoekel
approved these changes
Oct 26, 2025
Owner
|
@rileychou thank you for all of your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎵 Summary of Changes
This PR implements cmajor code for the Cabasa instrument. It takes a lot of inspiration from #80 , but I made the following changes:
burstSpacingandreleaseInto more accurately reflect a cabasa.🏷️ Type of Change
💡 Motivation/Reason
I wanted to create a sound that is not drum-like this time. I also didn't know about the cabasa before, and it was fun to play around with different filters!
🧪 Testing Done
npm run build)Cmajor: Run patchcommand🔗 Related Issues
Fixes #42
📝 Additional Notes
Any additional context, screenshots, or notes for reviewers
Screen.Recording.2025-10-23.at.9.52.06.PM.mov
📋 Checklist