Fix: handle filenames with spaces in kernbench script#1299
Open
kumarsgoyal wants to merge 1 commit intolinux-test-project:masterfrom
Open
Fix: handle filenames with spaces in kernbench script#1299kumarsgoyal wants to merge 1 commit intolinux-test-project:masterfrom
kumarsgoyal wants to merge 1 commit intolinux-test-project:masterfrom
Conversation
Update the kernel source caching loop to correctly handle filenames
containing spaces, newlines, and other special characters.
The previous implementation used a for loop over backtick-evaluated
`find`, which relied on word splitting and broke on filenames with
whitespace. This resulted in errors such as:
cat: ./tools/testing/selftests/devices/probe/boards/Dell: No such file or directory
cat: Inc.,XPS: No such file or directory
Replace the loop with a null-delimited `find` pipeline using
`-print0` and `read -r -d ''`, ensuring all valid filenames are
processed safely.
Signed-off-by: Sahil Kumar <kumar.sgoyal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: handle filenames with spaces in kernbench script
Update the kernel source caching loop to correctly handle filenames
containing spaces, newlines, and other special characters.
The previous implementation used a for loop over backtick-evaluated
find, which relied on word splitting and broke on filenames withwhitespace. This resulted in errors such as:
Replace the loop with a null-delimited
findpipeline using-print0andread -r -d '', ensuring all valid filenames areprocessed safely.
Signed-off-by: Sahil Kumar kumar.sgoyal@gmail.com