feat(S3UriPath): Add S3UriPath class to override __fspath__() for pandas competibility#209
Open
SafetyMary wants to merge 3 commits intoliormizr:masterfrom
Open
feat(S3UriPath): Add S3UriPath class to override __fspath__() for pandas competibility#209SafetyMary wants to merge 3 commits intoliormizr:masterfrom
SafetyMary wants to merge 3 commits intoliormizr:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add S3UriPath class for pandas competibility
Add a new S3UriPath class to override
__fspath__for pandas read methods competitibilityImplementation
__init__.pyfor python 3.12 or above only__fspath__returnto_uri()due to URL encodingpd.readfrom s3 would require connection to s3 bucketsTesting issues
Boto3 versioning
The stated boto3 version 1.16.35 in
setup.pycannot be imported with the following error. So I used 1.42.48 to run testing insteadFailed case
All test cases passed except the following. This test case also failed at the master branch so i believe it is unrelated to this PR.