Generic atomic operation#2005
Merged
Merged
Conversation
MrBurmark
reviewed
Mar 17, 2026
MrBurmark
reviewed
Mar 17, 2026
MrBurmark
reviewed
Mar 18, 2026
MrBurmark
reviewed
Mar 18, 2026
adayton1
commented
May 29, 2026
MrBurmark
reviewed
May 29, 2026
MrBurmark
reviewed
May 29, 2026
MrBurmark
reviewed
May 29, 2026
MrBurmark
approved these changes
May 29, 2026
johnbowen42
approved these changes
Jun 3, 2026
johnbowen42
left a comment
Contributor
There was a problem hiding this comment.
I have two nits: one where we could replace a static_assert with concepts, one where extra performance could be gained with an early exit condition inside the generic loop. However I think this is fine as is and don't want to block
| old = desul::atomic_compare_exchange(acc, expected, operation(expected), | ||
| raja_default_desul_order {}, | ||
| raja_default_desul_scope {}); | ||
| } while (!RAJA::util::bit_equal(old, expected)); |
Contributor
There was a problem hiding this comment.
we might get a small performance hit here whenever we perform an operation like <=, where early exit is possible upon equality
Member
Author
There was a problem hiding this comment.
Yeah, that's likely. I was thinking we could add an overload with short-circuiting in a future PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use case:
Design discussion points: