Add CUDA 13 support#2011
Conversation
| @@ -0,0 +1,161 @@ | |||
| # Copyright Spack Project Developers. See COPYRIGHT file for details. | |||
There was a problem hiding this comment.
Do you plan to have the camp package changes pushed up to the spack package repo?
There was a problem hiding this comment.
Yes, once CI tests are working PR for spack-packages / camp / BLT will be done.
rhornung67
requested review from
MrBurmark,
adayton1,
artv3,
johnbowen42 and
rchen20
| diff --git a/include/camp/resource.hpp b/include/camp/resource.hpp | ||
| index 58df206..763aa20 100644 | ||
| --- a/include/camp/resource.hpp | ||
| +++ b/include/camp/resource.hpp | ||
| @@ -12,6 +12,7 @@ http://github.com/llnl/camp | ||
| #define __CAMP_RESOURCE_HPP | ||
|
|
||
| #include <cstring> | ||
| +#include <stdexcept> | ||
| #include <memory> | ||
| #include <mutex> | ||
| #include <type_traits> | ||
| diff --git a/include/camp/resource/host.hpp b/include/camp/resource/host.hpp | ||
| index c765175..4428c57 100644 | ||
| --- a/include/camp/resource/host.hpp | ||
| +++ b/include/camp/resource/host.hpp | ||
| @@ -13,6 +13,7 @@ http://github.com/llnl/camp | ||
|
|
||
| #include "camp/resource/event.hpp" | ||
| #include "camp/resource/platform.hpp" | ||
| +#include <cstdlib> | ||
|
|
||
| namespace camp | ||
| { |
There was a problem hiding this comment.
Thanks for looking in to this, Steve! Should we just directly update Camp and release it, rather than patching it? Same question for BLT.
There was a problem hiding this comment.
That camp patch is in the upstream spack-packages repo, it is there to support building older versions of camp (pre camp 2022.10). Local copy was done to get CI build system working until camp can be updated for CUDA.
|
This PR fixes #1958 This PR depends on CAMP changes llnl/camp#196 |
|
@rhornung67 @MrBurmark @adayton1 @artv3 @johnbowen42 @rchen20 @adrienbernede TPLs have all been updated and CUDA 13 PR for RAJA finally ready for review. |
rchen20
left a comment
rchen20
left a comment
There was a problem hiding this comment.
Does this update to a new BLT release, or just BLT/develop?
It is a new BLT release 0.7.2 release. Some changes in BLT were needed for Cuda 13. |
7 participants
Add support for CUDA 13
Small CUDA 13 changes due to removed and changed APIs.
Added test for CUDA 13 to matrix CI.
Updated BLT submodule to 7.2 release with CUDA 13 support.
The RAJA spack package has been updated to enable CUDA 13 builds.