Skip to content

Removed extraneous yout copy#814

Merged
gardner48 merged 45 commits intofeature/fes-stagingfrom
feature/fes-yout-copy
Mar 25, 2026
Merged

Removed extraneous yout copy#814
gardner48 merged 45 commits intofeature/fes-stagingfrom
feature/fes-yout-copy

Conversation

@drreynolds
Copy link
Copy Markdown
Collaborator

Removed extraneous copy of yn into yout in ONE_STEP mode for ARKODE (since ycur aliases yout, and just prior to this copy ycur was copied into yn).

…aliases yout, and just prior to this copy ycur was copied into yn)
Comment thread CHANGELOG.md Outdated
Comment thread doc/shared/RecentChanges.rst Outdated
Co-authored-by: Steven Roberts <roberts115@llnl.gov>
@drreynolds
Copy link
Copy Markdown
Collaborator Author

This is the second in a sequence of PRs for ARKODE to support our FES collaborators. Please review this one after #813. When the stack is complete, we'll do a final PR into develop

@drreynolds drreynolds mentioned this pull request Jan 20, 2026
@gardner48 gardner48 added this to the SUNDIALS Next milestone Jan 20, 2026
@drreynolds
Copy link
Copy Markdown
Collaborator Author

This PR should be ready to review -- all CI issues resulting from the new release have been resolved.

@balos1
Copy link
Copy Markdown
Member

balos1 commented Feb 4, 2026

Does this need to be merged after #813?

@drreynolds
Copy link
Copy Markdown
Collaborator Author

Does this need to be merged after #813?

That was the plan, so that each individual review focused only on one theme. However, this one is so small I don't think it would pollute the review for #813, so it could be reviewed/merged at any time.

Comment thread CHANGELOG.md
Comment thread src/arkode/arkode.c
Base automatically changed from feature/stageprocessing to feature/fes-staging March 24, 2026 16:49
@gardner48 gardner48 merged commit 30261df into feature/fes-staging Mar 25, 2026
49 checks passed
@gardner48 gardner48 deleted the feature/fes-yout-copy branch March 25, 2026 03:35
gardner48 added a commit that referenced this pull request Apr 3, 2026
…ies, LSRKStep updates, Preallocate, GetStageIndex) (#897)

Combined updates from several PRs:
* #813: step pre/post functions, stage postprocessing, and pre RHS
functions
* #814: removed an extraneous copy of `yn` into `yout` when running in
ONE_STEP mode for ARKODE
* #815: various cleanup to the LSRKStep module
* #819: user-callable routine to retrieve the current stage index
* #886: user-callable `ARKodeInit` routine to finalize ARKODE and
allocate remaining memory before `ARKodeEvolve` is called

---------

Co-authored-by: David Gardner <gardner48@llnl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants