Feature: User-callable routine to retrieve the current stage index#819
Feature: User-callable routine to retrieve the current stage index#819gardner48 merged 141 commits intofeature/fes-stagingfrom
Conversation
…x and the total number of method stages
drreynolds
requested review from
balos1,
cswoodward and
gardner48
as code owners
|
This is the sixth (and last) in a sequence of PRs for ARKODE to support our FES collaborators. Please review this one after #818. When the stack is complete, we'll do a final PR into |
…from the last upstream PR)
|
A data point: I've tested this in combination with in Gkeyll and it seems to work fine. |
…x_stages to be consistent with other methods; updated comments
There was a problem hiding this comment.
- A minor inconsistency between the
istagevalue and the logging output in SSP104 (istage = 5ends early and the logging foristage = 9andistage = 10is combined) - A minor issue in MRIStep where
istagehas the same value for the final stage and embedding - Suggestions to consistently refer to a stage by its index instead of count in LSRKStep comments
- Small doc and other suggestions
|
@gardner48: I've addressed all your PR comments, taking action on all but one, where instead I explained why I'd like to keep it as-is. If you're good with that explanation, then once this passes the CI I think it's ready to approve. (It's possible that some of these PR revisions might adjust some of the logging output, so it could take a few commits to resolve CI testing). |
gardner48
left a comment
gardner48
left a comment
There was a problem hiding this comment.
Minor logging fix and a suggestion to note that istage is slightly different in MRIStep
gardner48
left a comment
gardner48
left a comment
There was a problem hiding this comment.
Looks good, just waiting on the CI now
|
Strangely, that previous litgen CI failure is resurfacing periodically. |
…the answers repo)
…ies, LSRKStep updates, Preallocate, GetStageIndex) (#897) Combined updates from several PRs: * #813: step pre/post functions, stage postprocessing, and pre RHS functions * #814: removed an extraneous copy of `yn` into `yout` when running in ONE_STEP mode for ARKODE * #815: various cleanup to the LSRKStep module * #819: user-callable routine to retrieve the current stage index * #886: user-callable `ARKodeInit` routine to finalize ARKODE and allocate remaining memory before `ARKodeEvolve` is called --------- Co-authored-by: David Gardner <gardner48@llnl.gov>
3 participants
This PR adds the function
ARKodeGetStageIndexthat returns the index of the stage currently being processed, and the total number of stages in the method, for users who must compute auxiliary quantities in their IVP right-hand side functions during some stages and not others (e.g., in all but the first or last stage). It also adds functions to retrieve the last saved state (yn) and the corresponding time (tn).