Tools: Add CLI interface for suntools#884
Merged
Merged
Conversation
This reverts commit 6ab14d8.
This reverts commit 6ab14d8.
…eature/suntools-library-parse-logs
balos1
requested review from
cswoodward,
drreynolds and
gardner48
as code owners
gardner48
changed the title
…ibrary-parse-logs
gardner48
requested changes
May 31, 2026
#884 (comment) #884 (comment) #884 (comment) #884 (comment) #884 (comment) #884 (comment) Simplify the log filtering path by removing the extra log-line helpers, using parsed payload lengths to keep array continuations, and deleting the duplicate _get_history definition. Signed-off-by: Cody Balos <balos1@llnl.gov>
#884 (comment) #884 (comment) Make the suntools Python tests share one repo-local import setup, rename the CLI helper to reflect what it runs, and fix the unit-test PYTHONPATH to point at suntools/src for all of the tests. Signed-off-by: Cody Balos <balos1@llnl.gov>
gardner48
reviewed
Jun 1, 2026
gardner48
requested changes
Jun 2, 2026
Member
|
Looks like the issue is the CI container uses Python 3.8.10 but a newer Python is needed for the updated code |
Member
Author
I think we can change the minimum back to 3.8. I had bumped it to match sundials4py but I dont think we are using anything from 3.12 in these scripts. |
Member
I think there is some stuff like |
gardner48
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a CLI interface to suntools along with a command to parse logs and filter them.
This is a part of a chain of PRs for suntools, starting with #883.