feat(metrics): expose kine metrics via /metrics/kine#3910
Open
pascalbreuninger wants to merge 1 commit intomainfrom
Open
feat(metrics): expose kine metrics via /metrics/kine#3910pascalbreuninger wants to merge 1 commit intomainfrom
pascalbreuninger wants to merge 1 commit intomainfrom
Conversation
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Bind kine's metrics listener to 127.0.0.1:2381 and proxy it through the control plane on /metrics/kine when a database backing store is in use. Add a ServiceMonitor endpoint to scrape it. Snapshot restore explicitly disables the listener to avoid a port conflict with the running kine. Closes ENGCP-400 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
pascalbreuninger
force-pushed
the
issue/engcp-400
branch
from
296e1e3 to
24497f8
Compare
E2E Ginkgo Tests
|
cbalan
reviewed
Apr 30, 2026
cbalan
reviewed
Apr 30, 2026
cbalan
requested changes
Apr 30, 2026
cbalan
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
127.0.0.1:2381instead of0(disabled), so kine's Prometheus metrics are reachable inside the pod./metrics/kine, gated to non-etcd backing stores (embedded sqlite, embedded database, external database)./metrics/kinefor non-etcd deployments, with corresponding chart unit tests.Closes ENGCP-400
Test plan
🤖 Generated with Claude Code