Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new API function, ComposeTable::feed2, to provide additional control over composing input sequences. The changes update the release notes, add new test cases and expected outputs, and modify the main test runner in compose-tests/src/main.rs to utilize the new feed2 API along with updated error handling for modifiers.
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| kbvm/release-notes.md | Updated release notes to document the new ComposeTable::feed2 API |
| compose-tests/testcases/* | Added/updated test cases and expected outputs for the new API |
| compose-tests/src/main.rs | Modified the test_case2 function to use feed2 and handle modifiers |
mahkoh
force-pushed
the
jorth/compose-branch-points
branch
from
a647da5 to
eb958df
Compare
mahkoh
force-pushed
the
jorth/compose-branch-points
branch
from
eb958df to
69371d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.