feat: support optionValue in reference inputs#11270
Closed
louzhedong wants to merge 2 commits into
Closed
Conversation
Author
|
Follow-up: I fixed the lint/typecheck regression in useReferenceInputController and re-validated locally with:
At this point the remaining PR checks I can see are the external Vercel authorization gates, so there doesn't seem to be another code-side blocker on the branch. |
Member
|
Relationships in react-admin require that fkeys target the id field in the related table. If this is not your case, you can either map this logic to your data model in the data provider, or use other components than react-admin's ReferenceInputs. This is a foundational design decision that we won't challenge - it would have huge implications across the framework. So I'm sorry, but we won't merge your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
optionValuesupport toReferenceInputBase/useReferenceInputControllerso reference inputs can load the current record by an alternate key instead of always assumingid.This keeps the default
idbehavior unchanged, but whenoptionValueis provided it:getListfiltered by that fieldallChoicesgetManyfor that lookup pathVerification:
node_modules\.bin\jest.cmd packages/ra-core/src/controller/input/useReferenceInputController.spec.tsx --runInBandnode_modules\.bin\jest.cmd packages/ra-core/src/controller/input/ReferenceInputBase.spec.tsx --runInBandnode_modules\.bin\tsc.cmd --noEmit -p packages/ra-core/tsconfig.json