ui: add support for frame expand/collapse via external input#1970
Open
jpue wants to merge 1 commit intomcallegari:masterfrom
Open
ui: add support for frame expand/collapse via external input#1970jpue wants to merge 1 commit intomcallegari:masterfrom
jpue wants to merge 1 commit intomcallegari:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://www.qlcplus.org/forum/viewtopic.php?t=19349
This PR adds the ability to expand/collapse a VC (solo) frame via a keyboard shortcut or an external input to v4. The already existing code for the “enable” button was used as a reference for the implementation.
Furthermore, some existing code sections have been encapsulated in blocks so that in longer methods, local variables only exists where they are actually used.
Please note that I tested the keyboard shortcut and external input part (using a second QLC+ instance and the OSC plugin on
localhost). However, I have not been able to test this (or the feedback functionality) on real hardware.